congr: add congr pat and congr * variants#1016
Merged
Merged
Conversation
Gustavo2622
reviewed
Jun 1, 2026
Gustavo2622
reviewed
Jun 1, 2026
Gustavo2622
approved these changes
Jun 1, 2026
strub
added a commit
that referenced
this pull request
Jun 1, 2026
[t_congr_from_skeleton], [t_congr_pattern] and [t_congr_star] now live in [EcLowGoal] alongside [t_congr] and take only OCaml-level data (forms, idents, unienv). [EcHiGoal] keeps only the AST-elaboration wrappers. Same external semantics; reviewer feedback on PR #1016.
`congr pat` requires the pattern to match both sides of the goal equality (or iff); each pattern variable yields one subgoal equating its bindings on the two sides. `congr *` walks both sides in lock-step without any reduction, emitting one subgoal per pair of differing positions. Both variants are first-order (binders are opaque, matching the existing `congr`'s behavior).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`congr pat` requires the pattern to match both sides of the goal
equality (or iff); each pattern variable yields one subgoal equating
its bindings on the two sides. `congr *` walks both sides in lock-step
without any reduction, emitting one subgoal per pair of differing
positions. Both variants are first-order (binders are opaque, matching
the existing `congr`'s behavior).